Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update update workflows #321

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Update update workflows #321

merged 4 commits into from
Jul 27, 2023

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Jun 17, 2023 •
edited
Loading

Summary

  1. Remove Java 11. This has gone end of life upstream, so it is being removed.
  2. Remove Java 19. This has gone end of life upstream, so it is being removed.
  3. Add Java 20. This is the new short-term release.
  4. Update Java 17 to use the new Github release update dependency. We can now use this to fetch dependencies from upstream instead of the custom updater. This works for Java 17 and Java 20.

Use Cases

Fix updaters.

Resolves #327

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@dmikusa dmikusa added semver:minor A change requiring a minor version bump type:dependency-upgrade A dependency upgrade labels Jun 17, 2023
@dmikusa dmikusa requested a review from a team as a code owner June 17, 2023 15:02
@dmikusa dmikusa added the note:on-hold We can't start working on this issue yet label Jun 17, 2023
anthonydahanne
anthonydahanne approved these changes Jun 17, 2023
View reviewed changes
Copy link
Member

@anthonydahanne anthonydahanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change introduces new archives for GraalVM 17 and 20, that now include native-image.
Before we can consider native-image as part of GraalVM, like @dmikusa said, 11 must be monitored or... deprecated... since it seems to not be distributed "officially" anymore, see: https://www.graalvm.org/downloads/

@dmikusa dmikusa marked this pull request as draft July 7, 2023 19:09
@dmikusa
Copy link
Contributor Author

dmikusa commented Jul 7, 2023

This needs a little more work. I missed required changes to buildpack.toml. Marking as a draft for now.

@dmikusa dmikusa marked this pull request as ready for review July 25, 2023 01:55
@dmikusa dmikusa removed the note:on-hold We can't start working on this issue yet label Jul 25, 2023
@dmikusa dmikusa mentioned this pull request Jul 25, 2023
Closed
@dmikusa
Copy link
Contributor Author

dmikusa commented Jul 25, 2023

I think this is ready to go now. Need a quick re-review. Thanks

@dmikusa
Update update workflows
f77a5b1 
1. Remove Java 11. This has gone end of life upstream, so it is being removed.
2. Remove Java 19. This has gone end of life upstream, so it is being removed.
3. Add Java 20. This is the new short-term release.
4. Update Java 17 to use the new Github release update dependency. We can now use this to fetch dependencies from upstream instead of the custom updater. This works for Java 17 and Java 20.

Signed-off-by: Daniel Mikusa <dan@mikusa.com>
@dmikusa
Remove installation of tools via gu
9329756 
Signed-off-by: Daniel Mikusa <dan@mikusa.com>
@dmikusa
Add native-image-svm dependencies
d71a973 
The way the libjvm support works, it needs a tag called `native-image-svm` for the bundled JDK+native image. This commit adds those, even though they are duplicates.

Signed-off-by: Daniel Mikusa <dan@mikusa.com>
@dmikusa
Fix typo, use github-release-dependency for update checks
45fb686 
Signed-off-by: Daniel Mikusa <dan@mikusa.com>
@dmikusa dmikusa merged commit fe98693 into main Jul 27, 2023
4 checks passed
@dmikusa dmikusa deleted the ci-updates branch July 27, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pivotal-david-osullivan pivotal-david-osullivan pivotal-david-osullivan approved these changes

@anthonydahanne anthonydahanne Awaiting requested review from anthonydahanne

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump type:dependency-upgrade A dependency upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support for java20
3 participants
@dmikusa @anthonydahanne @pivotal-david-osullivan